Skip to content

SRVKS-1222: Add section with Kourier and Istio diagrams #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

SRVKS-1222: Add section with Kourier and Istio diagrams #121

merged 1 commit into from
May 28, 2025

Conversation

ochromy
Copy link
Contributor

@ochromy ochromy commented Apr 8, 2025

Issue link:

Motivation:

  • We need to include the ingress diagrams in the downstream Serverless docs.
    BUT
  • The professional diagrams are not ready yet.
    THEREFORE
  • We want to add the diagrams (along with the necessary context) to the developer preview docs and link to them in the downstream docs until the professional diagrams are available.

Contents:

@openshift-ci-robot
Copy link

@ochromy: This pull request references SRVKS-1222 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target the "4.19.0" version, but no target version was set.

In response to this:

Issue link:

Motivation:

  • We need to include the ingress diagrams in the downstream Serverless docs.
    BUT
  • The professional diagrams are not ready yet.
    THEREFORE
  • We want to add the diagrams (along with the necessary context) to the developer preview docs and link to them in the downstream docs until the professional diagrams are available.

Contents:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ochromy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify Netlify
Copy link

netlify bot commented Apr 8, 2025 •
edited
Loading

✅ Deploy Preview for jazzy-shortbread-5f62b7 ready!

Name Link
🔨 Latest commit db43946
🔍 Latest deploy log https://app.netlify.com/sites/jazzy-shortbread-5f62b7/deploys/68241b866310270008abe6da
😎 Deploy Preview https://deploy-preview-121--jazzy-shortbread-5f62b7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ochromy
Copy link
Contributor Author

ochromy commented May 5, 2025

Hello @nainaz,
Your input or ACK on this PR — as well as on #125 (Serverless architecture diagram in midstream) — would be much appreciated.
Both involve adding the makeshift diagrams into the midstream (Developer Preview) docs.

nainaz
nainaz reviewed May 8, 2025
View reviewed changes
nainaz
nainaz suggested changes May 8, 2025
View reviewed changes
Copy link

@nainaz nainaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one comment and assuming the diagrams are same as provided in the Jira and docs :)

@ochromy
SRVKS-1222: Add section with Kourier and Istio diagrams
db43946 
Add diagrams in PNG

Add figure names to diagrams

Add assembly to NAV

NAV name correction

Review feedback for SRVKS-1222
@ochromy ochromy mentioned this pull request May 14, 2025
Merged
@ochromy ochromy mentioned this pull request May 26, 2025
Merged
1 task
@nainaz
Copy link

nainaz commented May 27, 2025

LGTM

@creydr creydr merged commit f6624b3 into openshift-knative:master May 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nainaz nainaz nainaz requested changes

Assignees
No one assigned
Labels
jira/valid-reference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ochromy @openshift-ci-robot @nainaz @creydr